fix: Handle value error when convert shmem to binary size #2972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
3 tasks
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
lablup-octodog
pushed a commit
that referenced
this pull request
Oct 25, 2024
Backported-from: main (24.12) Backported-to: 24.09 Backport-of: 2972
lablup-octodog
pushed a commit
that referenced
this pull request
Oct 25, 2024
Backported-from: main (24.12) Backported-to: 24.03 Backport-of: 2972
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 25, 2024
) Co-authored-by: Sanghun Lee <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 25, 2024
) Co-authored-by: Sanghun Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BinarySize.from_str()raisesValueErrorwhen it gets an empty string value.Add robust type hint and error handling when convert
shmemintoBinarySizeChecklist: (if applicable)